Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify your start #16

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Simplify your start #16

wants to merge 2 commits into from

Conversation

Rinatum
Copy link

@Rinatum Rinatum commented Jul 27, 2021

  1. update requirements.txt
  2. add dockerfile
  3. add imageio.imsave
  4. add tqdm for main loops

Rinatum and others added 2 commits July 27, 2021 11:55
Comment on lines 1 to 2
torch==1.4.0
torchvision==0.5.0

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there ✋🏼,

I have run the train_interpreter.py file from this repo using torch and torchvision latest versions.
To do so, I have changed these two lines by:

-f https://download.pytorch.org/whl/torch_stable.html
torch==1.9.0+cu111
torchvision==0.10.0+cu111

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, Thank you

I didn't test this torch/torchvision versions because

torch==1.4.0
torchvision==0.5.0

were added by original author of this repo

Also you need to update Dockerfile to use cuda/cudann suitable for versions 1.9.0 and 0.10.0

Do you think the changes you proposed are needed?

Copy link

@DRTorresRuiz DRTorresRuiz Jul 28, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not really sure if these changes affect another functionality of this repo. So, I wouldn't include them directly.
However, from my point of view, I would try to update these versions to the latest PyTorch versions to avoid future problems (just like the "imsave" function was deprecated). Moreover, the use of recent versions would mean greater support from the PyTorch community.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants